AppsFlyerSDK / appsflyer-unity-plugin

AppsFlyer Unity Plugin
MIT License
156 stars 64 forks source link

AppsFlyerSDK.IAppsFlyerNativeBridge.attributeAndOpenStore marked as iOS only, after 6.6 #180

Closed IoannisFMG closed 1 year ago

IoannisFMG commented 2 years ago

Hi! We recently had to update the appsflyer SDK version from 6.4 to 6.8 and I see that the AppsFlyerSDK.IAppsFlyerNativeBridge.attributeAndOpenStore stopped working on Android devices. Searching the code revealed that the call has been marked as iOS only in the Android Bridge file.

I have checked the Android and Unity plugin changelogs and I saw no reference or reason this might have happened. I also saw that the native code that actually handles that is still in the java file, only the bridge doesn't call it.

Was this marked as iOS only erroneously? Did something change without being documented?

af-margot commented 2 years ago

Hi,

Thank you for reaching out! It seems that it is indeed an error, we will investigate it. If the error is confirmed, we will fix it and include it in one of our next releases. In the meantime, please reach out to our support@appsflyer.com. They will be able to help you with relevant questions about this matter.

IoannisFMG commented 2 years ago

The most easy way to fix this, as far as I see, is to just call the other attributeAndOpenStore from the exposed one.

public void attributeAndOpenStore(string appID, string campaign, Dictionary<string, string> userParams, MonoBehaviour gameObject)
{
    attributeAndOpenStore(appID, campaign, userParams);
}

Other ways would require refactoring and/or optional parameters.

af-margot commented 2 years ago

Hi @IoannisFMG,

You can implement this solution in the meantime until we are releasing the next version.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 14 days since being marked as stale.