Closed jchojna closed 2 years ago
Good job! tada A couple of issues to resolve before merging:
- Images don't load in the map popup:
The
absolute_location
column is written to the CSV on export, but it is essentially ignored when importing. This inconsistency can be troublesome in the future. I see two clean solutions:
- Implement a mechanism to add custom properties on import, but ignore them on export. Might require serious refactoring.
- Prepend the image DB path to the (relative) location everywhere where the absolute path is needed. We'll need to pass around the DB path via props / function arguments - not ideal, but simple. I'd prefer this solution.
Bulletpoing 1 - this is strange, it works for me all the time. How can I reproduce?
Changes
Closes #179
How to test