search

Appsilon / reactable.extras

Extra features for reactable package
https://appsilon.github.io/reactable.extras/
38 stars 4 forks source link

[Bug]: Cannot make custom input working #48

Closed patzaw closed 9 months ago

patzaw commented 9 months ago

Guidelines

Project Version

0.2.0

Platform and OS Version

No response

Existing Issues

No response

What happened?

Hello

I've tried to run the example provided in the package site home page (https://appsilon.github.io/reactable.extras/index.html). The custom inputs do not appear as expected. When I try to click on a cell that what supposed to be a button nothing happen. I've tried on different systems: RHEL7 rstudio server, windows10 rstudio desktop and posit cloud. Here is the link to the posit cloud project : https://posit.cloud/content/7196779. My main web browser is Microsoft Edge (Version 119.0.2151.93).

I can't see what I'm doing wrong...

Thanks for sharing this promising package by the way.

Steps to reproduce

  1. Go to https://posit.cloud/content/7196779
  2. Run the shiny app in the shiny_test folder

Expected behavior

The table with the custom input displayed correctly and functional.

Attachments

No response

Screenshots or Videos

No response

Additional Information

No response

jakubnowicki commented 9 months ago

Hi @patzaw Most probably, this is related to a recent change in htmlwidgets@1.6.3 that breaks reactable::JS function. We are waiting for the new version of reactR to be released on CRAN - this should fix the problem. In the meantime, as a workaround, you can try downgrading htmlwidgets to version 1.6.2 or installing the development version of reactR (remotes::install_github("react-R/reactR@develop")).

patzaw commented 9 months ago

I've just installed the development version of reactR and indeed it works now. Thanks @jakubnowicki for the efficient workaround. Should I close the issue?

jakubnowicki commented 9 months ago

Please leave it open; I'll close it once the new version of reactR is released.

jakubnowicki commented 9 months ago

htmlwidgets@1.6.4 reverted the breaking change, which fixed the issue with custom inputs.