search

Appsilon / rhino

Build high quality, enterprise-grade Shiny apps at speed
https://appsilon.github.io/rhino
287 stars 24 forks source link

Use sparse checkout in E2E workflow #545

Closed kamilzyla closed 8 months ago

kamilzyla commented 8 months ago

Changes

Use actions/checkout@v4 with sparse-checkout instead of Bhacaz/checkout-files@v2, which is not very popular and doesn't seem to work on PRs originating from external repositories (problem encountered on #496).

How to test

If the E2E workflow still passes, we should be good.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a5da6c5) 17.82% compared to head (4ccc481) 17.82%.

:exclamation: Current head 4ccc481 differs from pull request most recent head 7be491c. Consider uploading reports for the commit 7be491c to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #545 +/- ## ======================================= Coverage 17.82% 17.82% ======================================= Files 9 9 Lines 404 404 ======================================= Hits 72 72 Misses 332 332 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jakubnowicki commented 8 months ago

@kamilzyla the CI fails for Ubuntu - oldrel, PTAL.

kamilzyla commented 8 months ago

@jakubnowicki Our E2E tests are flaky - Cypress times out occasionally. Passed on 3rd attempt.

jakubnowicki commented 8 months ago

@jakubnowicki Our E2E tests are flaky - Cypress times out occasionally. Passed on 3rd attempt.

Can we do anything about that? Please at least add an issue.

kamilzyla commented 8 months ago

I'm confident we can do something about it, but I think it needs a deeper investigation. Issue created here: #546.