search

Appsilon / rhino

Build high quality, enterprise-grade Shiny apps at speed
https://appsilon.github.io/rhino
278 stars 24 forks source link

Remove `observeEvent` anti-pattern from docs #554

Closed alexverse closed 5 months ago

alexverse commented 5 months ago

Updates documentation to avoid observeEvent anti-pattern, and simplifies reactive graphs.

Changes

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7d3662f) 17.73% compared to head (b6432d7) 17.73%.

:exclamation: Current head b6432d7 differs from pull request most recent head 86aa6a8. Consider uploading reports for the commit 86aa6a8 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #554 +/- ## ======================================= Coverage 17.73% 17.73% ======================================= Files 9 9 Lines 406 406 ======================================= Hits 72 72 Misses 334 334 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alexverse commented 5 months ago

Thank you @kamilzyla. I will address the other issues you mentioned in a subsequent PR.