Appsilon / rhino

Build high quality, enterprise-grade Shiny apps at speed
https://appsilon.github.io/rhino
287 stars 24 forks source link

Box universal import linter #555

Closed radbasa closed 8 months ago

radbasa commented 8 months ago

Changes

How to test

  1. Unit tests for box_universal_import_linter() exist
  2. Locally install rhino, version should be 1.7.0.9001, initialize a new rhino application then proceed to declare box imports.
  3. rhino::lint_r() should find and point to all package[...] and path/to/file[...] imports.
  4. Or, with an existing rhino app, add box_universal_import_linter = rhino::box_universal_import_linter() to .lintr.
  5. rhino::lint_r() should find and point to all package[...] and path/to/file[...] imports.
codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7d3662f) 17.73% compared to head (ec2ae8b) 20.85%.

:exclamation: Current head ec2ae8b differs from pull request most recent head 58fe353. Consider uploading reports for the commit 58fe353 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #555 +/- ## ========================================== + Coverage 17.73% 20.85% +3.11% ========================================== Files 9 10 +1 Lines 406 422 +16 ========================================== + Hits 72 88 +16 Misses 334 334 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.