Closed kamilzyla closed 7 months ago
Attention: 25 lines
in your changes are missing coverage. Please review.
Comparison is base (
a72120b
) 26.91% compared to head (4b1dfc4
) 28.72%.:exclamation: Current head 4b1dfc4 differs from pull request most recent head 0d2af1b. Consider uploading reports for the commit 0d2af1b to get more accurate results
Files | Patch % | Lines |
---|---|---|
R/app.R | 60.93% | 25 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes
A major refactor of
rhino::app()
. Each change corresponds to a single commit - it might be easier to review them one by one:R/app.R
with top-down approach: start withrhino::app()
and go from more general to more specific functions.load_main_source()
andload_main_box()
helpers to clearly distinguish these two mechanisms.rhino::app()
more readable with threeconfigure_*()
functions.with_head_tags()
) doesn't need to handle multiple cases.with_head_tags()
.rhino::app()
usingload_main()
andmake_app()
helpers.This PR is intended to be pure refactoring, so Rhino behavior should remain unchanged. However, the normalization step (4) actually has a user-observable benefit: the
request
parameter is now correctly passed to the UI if it uses it (closes #395).Additional testing
The How-to: Use shinymanager presents an example which uses both
shinymanager
and Shiny bookmarking. I have used it as a basis for testing all settings oflegacy_entrypoint
.