search

Appsilon / rhino

Build high quality, enterprise-grade Shiny apps at speed
https://appsilon.github.io/rhino
287 stars 24 forks source link

Lazy refactor #558

Closed kamilzyla closed 7 months ago

kamilzyla commented 7 months ago

Changes

Last small refactor before introducing auto-reload:

  1. Simplify and bundle the server reloading workaround in a single fix_server function.
  2. Force the evaluation of arguments in higher-order functions to avoid the pitfalls of lazy evaluation.
codecov-commenter commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a7df8de) 28.72% compared to head (3ac5423) 29.31%.

:exclamation: Current head 3ac5423 differs from pull request most recent head ab48af3. Consider uploading reports for the commit ab48af3 to get more accurate results

Files Patch % Lines
R/app.R 87.50% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #558 +/- ## ========================================== + Coverage 28.72% 29.31% +0.59% ========================================== Files 10 10 Lines 477 481 +4 ========================================== + Hits 137 141 +4 Misses 340 340 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.