Appsilon / rhino

Build high quality, enterprise-grade Shiny apps at speed
https://appsilon.github.io/rhino
278 stars 24 forks source link

box_usage_linter #571

Closed radbasa closed 2 months ago

radbasa commented 4 months ago

Changes

Packages

Local functions

Box modules

TODO

Local functions

How to test

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.26%. Comparing base (0ff3c44) to head (311de91). Report is 18 commits behind head on main.

:exclamation: Current head 311de91 differs from pull request most recent head 1172732. Consider uploading reports for the commit 1172732 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #571 +/- ## =========================================== + Coverage 34.11% 59.26% +25.14% =========================================== Files 10 17 +7 Lines 554 896 +342 =========================================== + Hits 189 531 +342 Misses 365 365 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

radbasa commented 4 months ago

@jakubnowicki I added

  box::use(
    path/to/module1,
    path/to/module2[a, b, c],
    path/to/module3[...]
  )

to the test cases where it makes sense. All tests just worked as expected. When you have time, please take a look. It was a surprise for me.