search

Appsilon / rhino

Build high quality, enterprise-grade Shiny apps at speed
https://appsilon.github.io/rhino
293 stars 25 forks source link

Support {bslib} in Rhino #596

Closed kamilzyla closed 4 months ago

kamilzyla commented 5 months ago

Changes

Closes #595. Implements the changes proposed in Design Doc: {bslib} in Rhino:

  1. Add sass: custom configuration option and handle it in build_sass().
  2. Attach favicon and minified files only if they exist (check each time the app is reloaded).
  3. Update documentation (how-to, rhino.yml, changelog).
codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 44.44444% with 10 lines in your changes missing coverage. Please review.

Project coverage is 20.29%. Comparing base (07f2f56) to head (1f061c3).

:exclamation: Current head 1f061c3 differs from pull request most recent head 565ef98

Please upload reports for the commit 565ef98 to get more accurate results.

Files Patch % Lines
R/app.R 57.14% 6 Missing :warning:
R/tools.R 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #596 +/- ## ========================================== - Coverage 20.65% 20.29% -0.36% ========================================== Files 9 9 Lines 460 468 +8 ========================================== Hits 95 95 - Misses 365 373 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.