Did an update broke the themes?

[vgeo999]

Hi there, first of all thank you very much for semantic.dashboard! I try to use it in my current project and so far I'm happy with the layout (allthough it seems application-titles are still not possible to add, but nevermind). A few days ago, I updated my shiny server and all related packages and then realized my whole application turned white instead of having this "slate"-theme. In fact, the box-labels appear to react when changing the theme, but anything else stays white. Is that, because of the new updates? Can I fix it somehow without getting back to the old versions? Attached an image, where I ran some sample code of yours, recproducing the theme issue for darkly-theme (now white as well).

Thank you very much in advance! Greetings from germany, Liz

PS: SessionInfo() R version 3.6.3 (2020-02-29) Platform: x86_64-w64-mingw32/x64 (64-bit) Running under: Windows 10 x64 (build 18362)

Matrix products: default

locale: [1] LC_COLLATE=German_Germany.1252 LC_CTYPE=German_Germany.1252 LC_MONETARY=German_Germany.1252 LC_NUMERIC=C
[5] LC_TIME=German_Germany.1252

attached base packages: [1] stats graphics grDevices utils datasets methods base

other attached packages: [1] DT_0.13 plotly_4.9.2.1 semantic.dashboard_0.1.5 shiny.semantic_0.3.0 ggplot2_3.3.0
[6] mailR_0.4.1 shinyBS_0.61 shinyjs_1.1 shinyWidgets_0.5.1 shiny_1.4.0.2
[11] xlsx_0.6.3 stm_1.3.5

loaded via a namespace (and not attached): [1] tidyselect_1.0.0 purrr_0.3.4 rJava_0.9-12 lattice_0.20-38 colorspace_1.4-1 vctrs_0.3.1 viridisLite_0.3.0 [8] htmltools_0.4.0 yaml_2.2.1 rlang_0.4.5 R.oo_1.23.0 later_1.0.0 pillar_1.4.3 glue_1.4.0
[15] withr_2.2.0 R.utils_2.9.2 matrixStats_0.56.0 lifecycle_0.2.0 stringr_1.4.0 munsell_0.5.0 gtable_0.3.0
[22] R.methodsS3_1.8.0 htmlwidgets_1.5.1 fastmap_1.0.1 crosstalk_1.1.0.1 httpuv_1.5.2 xlsxjars_0.6.1 Rcpp_1.0.3
[29] xtable_1.8-4 promises_1.1.0 scales_1.1.0 jsonlite_1.6.1 mime_0.9 digest_0.6.25 stringi_1.4.6
[36] dplyr_0.8.5 grid_3.6.3 tools_3.6.3 magrittr_1.5 lazyeval_0.2.2 tibble_3.0.1 tidyr_1.0.2
[43] crayon_1.3.4 pkgconfig_2.0.3 ellipsis_0.3.0 Matrix_1.2-18 data.table_1.12.8 assertthat_0.2.1 httr_1.4.1
[50] rstudioapi_0.11 R6_2.4.1 compiler_3.6.3

[dokato]

Hey @vgeo999 , thank you for reporting this. Indeed we've made quite a few changes to shiny.semantic (that sits under the hood of semantic.dashboard) recently. They shouldn't affect themes though, so this is something unexpected. I'll test that and let you know soon.

[vgeo999]

Hi @dokato , thank you very much! Any news yet? When I inspect the ui.segment from my semantic.dashboard-application, it seems the background color is hard coded to be white. I can't remember seeing this when the theme was working before, but it might be completely unrelated =D

Thank you for investigating! I'm looking forward to have the style opportunity again :) Greetings from Germany, Liz

[dokato]

hi @vgeo999 , in fact, I did, but unfortunately don't have an answer for you atm. I've checked that the css files from semantic forest are loaded correctly from our CDN. For some strange reason they must be overridden somehow, but I have not yet identified where.

Apologies for that, I imagine it must be very frustrating. But please give us a bit more time. We are working hard on https://github.com/Appsilon/shiny.semantic that semantic.dashboard relies on right now. It's in the midst of huge changes, but we didn't plan to break anything with themes :P We plan to release new version of shiny.semantic on CRAN at the end of August. Hopefully, it will come with themes fixed!

[vgeo999]

Hi @dokato , how is it going? :) cheerz, Liz

[dokato]

Hey @vgeo999 , sorry for a late reply. Indeed we were working on resolving this issue recently. So far we still focused on the integration of semantic.dashboard with the latest updates to the v. 0.4.0 version of shiny.semantic, see https://github.com/Appsilon/shiny.semantic. So as you might have noticed in January we changed the engine of shiny.semantic from SemanticUI (that ceased to be developed) to FomanticUI (an actively developed community fork). Unfortunately, transition from one to another was quite challanging as there is not 100% overlap just yet. For example FomanticUI introduced new features as calendar input or sliders, that were not available in SemanticUI. It looks like https://semantic-ui-forest.com/ is not up to date with these changes and we heavily rely on them. Now we're thinking what's the best course of action is here, we could either introduced full support for a limited number of themes available in Fomantic, or try to introduce new features into SemanticUI, but again this would take some time...

[dokato]

We opened an issue for that here, please watch this thread for more updates: https://github.com/Appsilon/shiny.semantic/issues/295

[andrie]

I have traced this specific issue to the use of class="ui segment", and in the theme CSS files (including for darkly) a segment has a background colour of "white".

IMO the fix is to use class="ui content" instead. (At least, this is my hypothesis at the moment.)

I'll try to submit a PR.