search

Appsilon / shiny.info

Display simple diagnostic info of your Shiny app
https://appsilon.github.io/shiny.info/
Other
61 stars 8 forks source link

8 placing more than one box same corner #15

Closed mdubel closed 5 years ago

mdubel commented 5 years ago

This PR fully resolved #8 User is supposed to put all the info boxes in the single infoPanel (camel case used to be in line with Shiny mainPanel, sidebarPanel and so on; to be discussed) where position can be specified just once and boxes do not overlap themselves. If other positions are used inside they're overwritten by infoPanel position.

User still can put info boxes in different corners, can specify them outside the infoPanel (or not even use it at all if there is a single box in each corner). See app example for the usage.

I'll think through the idea you've mentioned in comment for the other PR.

lintr-bot commented 5 years ago

R/display.R:17:5: style: Place a space before left parenthesis, except in a function call.

​  if(isTRUE(any(grepl("infoPanel", sys.call(-8))))) {
    ^
dokato commented 5 years ago

@mdubel could you try to rebase to master to fix the CI?

mdubel commented 5 years ago

@mdubel could you try to rebase to master to fix the CI?

@dokato It is rebased and I can't quite find what CI does not like in my code. I'll examine it further.

dokato commented 5 years ago

@mdubel could you try to rebase to master to fix the CI?

@dokato It is rebased and I can't quite find what CI does not like in my code. I'll examine it further.

I think it's something related to pdf generation from manual. Check your NAMESPACE and make sure you called devtools::document()

lintr-bot commented 5 years ago

R/panel.R:20:38: style: Trailing whitespace is superfluous.

​ info_panel(..., position = position) 
                                     ^
mdubel commented 5 years ago

@dokato what is the status of this PR?

dokato commented 5 years ago

@mdubel I'm not a big fan of tryCatch solution. I'm trying to figure out if there is a way to parse sys.call output in a smarter way.

dokato commented 5 years ago

After closer look LGTM