Appsilon / shiny.react

Use React in Shiny applications.
https://appsilon.github.io/shiny.react
GNU Lesser General Public License v3.0
96 stars 12 forks source link

Support accessor set input #62

Closed averissimo closed 1 year ago

averissimo commented 1 year ago

Related issues

Changes description (include a screenshot if applicable!)

Peek 2023-01-20 18-55

Definition of Done checklist

averissimo commented 1 year ago

I believe I resolved all your comments @kamilzyla

Please take a look at the changes I did to setInput as it seemed redundant to have code in R and JS handling the index vs. accessor

I'm a bit ashamed of the time it took to figure out a bug I was having with (...args) to arguments with webpack 😅

averissimo commented 1 year ago

I dropped the ball on the documentation. Thank you for catching it!