search

Appsilon / shiny.react

Use React in Shiny applications.
https://appsilon.github.io/shiny.react
GNU Lesser General Public License v3.0
96 stars 12 forks source link

refactor: import Shiny from module #74

Closed jakubsob closed 1 year ago

jakubsob commented 1 year ago

Changes

Import Shiny from a module to hide implementation details how this object is retrieved. It keeps diff smaller and allows easier control how we access Shiny object (no need to change Shiny to window.Shiny in multiple files).

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (rmarkdown_support@17d6326). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                 Coverage Diff                 @@
##             rmarkdown_support     #74   +/-   ##
===================================================
  Coverage                     ?   9.72%           
===================================================
  Files                        ?       5           
  Lines                        ?     144           
  Branches                     ?       0           
===================================================
  Hits                         ?      14           
  Misses                       ?     130           
  Partials                     ?       0
andyquinterom commented 1 year ago

Love these changes! Thank you so much for the suggestions.!