Appsilon / shiny.semantic

Shiny support for powerful Fomantic UI library.
http://appsilon.github.io/shiny.semantic
Other
499 stars 97 forks source link

[Feature]: Enable placeholder in `numeric_input` #428

Closed osenan closed 1 year ago

osenan commented 1 year ago

Guidelines

Description

Right now argument placeholder is not used in a numeric_input altough it is included as an argument.

The following example app does not have a placeholder in the input when the value is NULL:

library(shiny)
library(shiny.semantic)
ui <- semanticPage(
  numeric_input("ex", "Select number", value = 3, placeholder = "type value")
)
server <- function(input, output, session) {}
shinyApp(ui, server)

Problem

In some contexts users might benefit from viewing a placeholder in a numeric_input

Proposed Solution

Including placeholder in the input tag and changing the checks

Alternatives Considered

A text_input could be used with current code

shyamtawli commented 1 year ago

Hey @osenan I want to contribute but can you guide me more?

osenan commented 1 year ago

Thanks @shyamtawli this issue has been already solved. Nevertheless, we appreciate your offer to contribute. Remeber you can colaborate by solving other open issues or requesting features that you consider interesting.

Best Regards, Oriol