Open DangerousWizardry opened 5 months ago
Hi, thank you for your contribution! Two questions:
update_dropdown_input()
has some discrepancies too?Here you'll find a reproducible example. It seems to come from named list including spaces in their names.
library(shiny)
library(shiny.semantic)
ui <- semanticPage(
title = "My page",
shiny.semantic::selectInput(
inputId = "item_picker",
label = "Choose your item",
choices = list()
)
)
server <- function(input, output, session) {
observe({
item_list <- list("my first item" = 1,"my second item" = 2)
shiny.semantic::updateSelectInput(session,
inputId = "item_picker",
label = "Choose your item",
choices = item_list,
selected = 2)
})
}
# Run the application
shinyApp(ui = ui, server = server)
Correct a bug where value is not correctly attributed to the data-value attribute in semantic selectInput when using named list as choices.
Have you read the Contributing Guidelines?
Description
Fix a bug when you use named list as choices list. jsonlite::toJSON badly handle the choices list when it came to R named list. Shiny expect a simple JS array. To do that we just have to unname & unlist the initial choices list to get a value vector.
Definition of Done
R CMD check
, linter, unit tests, spelling)..Rd
files withroxygen2::roxygenise()
)