April-Gras / obsidian-auto-timelines

Simple timeline generator plugin for story tellers using obsidian
MIT License
120 stars 5 forks source link

Modified image extraction to allow for size and CSS modifiers #169

Closed oricc closed 4 months ago

oricc commented 4 months ago

Image embeds in obsidian can be modified using a pipe syntax.

See:

Currently, the regex extracts all the pipes as part of the file name, which means any image modified by pipes can't be displayed in the timeline. This minor change takes the image name only before the pipe symbol to allow this.

An example: ![[image.png|200X200]] does not appear in the timeline in the current version but does after the change

April-Gras commented 4 months ago

image

Hey @oricc, thank you so much for this :pray: A great contribution, just one thing to fix You can run npx eslint . --config .eslintrc --ext .js,.jsx,.ts,.tsx to reproduce on your end

oricc commented 4 months ago

Hey @April-Gras, thanks for the quick feedback. I fixed the issue and verified it still works

April-Gras commented 4 months ago

Perfect! Now all that is left to do is to bump the version in the package.json by one patch so 0.13.2 -> 0.13.3

Run npm run version and commit the changes done to the files Very exited to see this released :sparkles:

oricc commented 4 months ago

Done 😊