search

AprilAndFriends / theoraplayer

A multi-threaded C++ library that plays video files supporting multiple codecs across platforms. Easy to use, fast, responsive, abstract interface and minimal dependencies, you'll soon be wondering how you lived without it! ;) Audio and Video interfaces are completely abstracted so the library can be used anywhere, regardless of what you use to display video frames and play audio samples (eg. OpenGL / OpenAL, Direct3D / DirectSound?, SDL / SDL_mixer, X11 / alsa ...) The library can pre-cache video frames and decoded audio samples for maximum efficiency and smooth playback, even on single-cpu systems. Currently, the library supports Theora on Windows, Mac, iOS, Linux, Android, WinRT and Windows Phone. H.264 is supported on Mac and iOS.
BSD 3-Clause "New" or "Revised" License
84 stars 43 forks source link

v1.2: Fix TheoraFileDataSource::getPosition() for Linux #35

Closed ivan-mogilko closed 2 years ago

ivan-mogilko commented 2 years ago

Hello, I can see that your repository has not been updated for a while, so wonder if it's okay to make a PR, especially that it's for an older version.

I'm currently using the v1.2 of theoraplayer to update some very old project, as next player's version(s) have a different api. v1.2 has a small mistake that breaks compilation on Linux; it was already fixed in 2.0 branch, so I thought I'd propose same fix for 1.2 to compile properly too.

borisblizzard commented 2 years ago

Looks fine to me. Confirmed and merged.

kspes commented 2 years ago

Yeah, sure! Cool :) Glad to see people are still using theoraplayer :) Can you share which project you are using it for?

ivan-mogilko commented 2 years ago

Can you share which project you are using it for?

It's a plugin someone made for a "Adventure Game Studio" game engine, for easier managing theora video playback. Recently I took it over for an upgrade: https://github.com/ivan-mogilko/ags-sprite3d