Fixed refine_edges keyword to allow it to be referenced in Python

AprilRobotics / apriltag

AprilTag is a visual fiducial system popular for robotics research.

https://april.eecs.umich.edu/software/apriltag

Other

1.47k stars 522 forks source link

Fixed refine_edges keyword to allow it to be referenced in Python #248

Closed DanielChaseButterfield closed 1 year ago

DanielChaseButterfield commented 1 year ago

This is to solve Issue #243. The functionality was already there, but "refine-edges" can't be used as a keyword argument in python because of the '-'.

christian-rauch commented 1 year ago

In the end, this was just a typo? Can you maybe rephrase the commit message saying that this fixes a typo in the apriltag_new parameters?

DanielChaseButterfield commented 1 year ago

@christian-rauch Sure! And yeah, looks like it was just a typo.

christian-rauch commented 1 year ago

@DanielChaseButterfield It now looks like you have two commits applying the same change and an additional merge commit. Can you rebase on master and squash such that this one-line change is in a single commit on this PR?

DanielChaseButterfield commented 1 year ago

Okay, I think it worked now :) @christian-rauch