search

AprilRobotics / apriltag

AprilTag is a visual fiducial system popular for robotics research.
https://april.eecs.umich.edu/software/apriltag
Other
1.47k stars 522 forks source link

Added a cmake option for building example executables #266

Closed jacobhuesman closed 1 year ago

jacobhuesman commented 1 year ago

I have a customized OpenCV install that caused the opencv example build to fail. I've added an cmake option to allow users to optionally disable building the examples.

christian-rauch commented 1 year ago

Can you give details why the compilation fails? Maybe we can just use a required version or components to check if a "normal" OpenCV is installed.

jacobhuesman commented 1 year ago

Can you give details why the compilation fails? Maybe we can just use a required version or components to check if a "normal" OpenCV is installed.

There's an additional Eigen dependency that get's pulled in.

I'm only interested in the core library since I have existing code that uses AprilTags, so being able to explicitly skip building the examples is useful for me.

The BUILD_EXAMPLES option is based on how OpenCV enables and disables building their examples: https://docs.opencv.org/4.x/db/d05/tutorial_config_reference.html

christian-rauch commented 1 year ago

Can you rebase your PR to fix the CI issue?

jacobhuesman commented 1 year ago

Rebased the PR