search

AprilRobotics / apriltag

AprilTag is a visual fiducial system popular for robotics research.
https://april.eecs.umich.edu/software/apriltag
Other
1.47k stars 522 forks source link

Duplicate definitions #276

Closed v1otusc closed 1 year ago

v1otusc commented 1 year ago

Duplicate definitions of zhash->nentries

christian-rauch commented 1 year ago

Can you explain where this is duplicated? zhash_t *zh is initialised just before this. Also, the commit message is not very explanatory.

wxmerkt commented 1 year ago

It's duplicated in L82 just above the fold, so this is correct. Unclear whether to remove L87 as proposed or alternatively L82 since the allocation related to nentries happens in L86 so it would be 'closer together'.

christian-rauch commented 1 year ago

It's duplicated in L82 just above the fold, so this is correct.

Right. I opened the file on GitHub with this change already applied.

Unclear whether to remove L87 as proposed or alternatively L82 since the allocation related to nentries happens in L86 so it would be 'closer together'.

We should remove L87 as suggested. Removing L82 would assume 0 for zh->nentries in the allocation at L86.