AprilRobotics / apriltag

AprilTag is a visual fiducial system popular for robotics research.
https://april.eecs.umich.edu/software/apriltag
Other
1.56k stars 535 forks source link

CMake install: Set .dll location to bin folder #300

Closed uilianries closed 10 months ago

uilianries commented 10 months ago

When building apriltag as a shared library on Windows, the DLLs could be installed in the bin folder, where the variable PATH should be properly configured, resulting in no problems at runtime.

Reference: https://cmake.org/cmake/help/latest/command/install.html#signatures

christian-rauch commented 10 months ago

I updated the actions in the CI pipeline. Can you rebase your PR?

uilianries commented 10 months ago

@christian-rauch Thank you! I just merged the master over my PR now. Regards!

christian-rauch commented 10 months ago

@christian-rauch Thank you! I just merged the master over my PR now. Regards!

Can you just rebase on master instead of emerging? I cannot do this in the repo myself.

uilianries commented 10 months ago

@christian-rauch Done, it's rebased now.