Use _WIN32 macro everywhere

[s-trinh]

Looks like a typo to me.

---

There is no WIN32 macros (at least with usual compilers):

• http://jdebp.info/FGA/predefined-macros-platform.html
• https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170
• https://sourceforge.net/p/predef/wiki/OperatingSystems/
• http://docwiki.embarcadero.com/RADStudio/Athens/en/Predefined_Macros

[christian-rauch]

Are you sure that the WIN32 macro does not exist? It may look like a typo because the other macros are named _WIN32, but WIN32 is indeed a defined macro.

This is definitely not a typo, since the macro exists. But I also find it confusing using WIN32 while all other Windows-specific sections of the code use _WIN32.

Can you rephrase your commit message to make clear that this is not a typo but rather to use a common macro or something similar?

[s-trinh]

I have updated the commit accordingly. Since it could be specific to MSVC, it is better to keep the original code IMO.

Luckily we have online tool... https://godbolt.org/z/8EKTj3sGc

[christian-rauch]

I have updated the commit accordingly. Since it could be specific to MSVC, it is better to keep the original code IMO.

Both macros are defined. But as you pointed out, this looks like a typo since all other Windows-specific sections use a different macro. I prefer to use the same macro for all OS-specific sections to avoid confusion.