search

AprilRobotics / apriltag_ros

A ROS wrapper of the AprilTag 3 visual fiducial detector
Other
358 stars 338 forks source link

Add guard before destroy method in TagDetector destructor #126

Closed maximilianwulf closed 2 years ago

maximilianwulf commented 2 years ago

Fixes #125

Was tested on our setup.

maximilianwulf commented 2 years ago

Thank you. I think I don't have the rights to merge this one?

wxmerkt commented 2 years ago

I was waiting for CI to come back and went to a meeting - thanks for the ping. Do you require a new patch release to use these changes?

On another note, I'd like to merge #81 - could you please check if that would work with your use cases? (It shouldn't affect the functionality, but changes the API)

maximilianwulf commented 2 years ago

Thank you very much :)

Do you require a new patch release to use these changes?

I guess it will come naturally with the next release, right? If yes, we are good for the moment.

could you please check if that would work with your use cases? (It shouldn't affect the functionality, but changes the API)

your PR changes Eigen::Isometry3d TagDetector::getRelativeTransform, right? We mainly use AprilTagDetectionArray detectTags as interface. So from our side #81 should be fine.