search

AprilSylph / XKit-Rewritten

🧰 The enhancement suite for Tumblr's new web interface
GNU General Public License v3.0
285 stars 48 forks source link

Quote Replies: Option to link to blog view in posts #1331

Open marcustyphoon opened 9 months ago

marcustyphoon commented 9 months ago

Concept

I personally prefer linking to my posts in the blog view (tumblr.com/myblog/123456) rather than on the blog network* (myblog.tumblr.com/post/123456). Quote Replies does the second one.

*unrelatedly, Quote Replies doesn't break if you have no custom theme... right? I guess I should test that.

enchanted-sword commented 9 months ago

Blogs with no set custom theme set seem to just use the default Tumblr theme.

marcustyphoon commented 9 months ago

I'm talking about this toggle! With it turned off, the "blog network" is entirely inaccessible. I just checked, though, and the redirect works fine.

enchanted-sword commented 9 months ago

Oh, yeah, makes sense that it would just get the mobile treatment.

marcustyphoon commented 9 months ago

Not sure what you mean by that, but it sounds like you've got it figured out :)

stale[bot] commented 8 months ago

This issue is unconfirmed, and has been labelled as stale due to inactivity. It will be closed automatically if no further activity occurs.

A project maintainer can mark an issue as confirmed by adding the help wanted label, the wontfix label, or an assignee.

marcustyphoon commented 5 months ago

I would really like to make this not default to the blog network, honestly, but I would also really like to not silently change what a user's created posts do. Too bad there's no realistic way I can think of to make a preference default different if the script has been previously installed than if it's freshly installed.

If only script metadata was in js instead of json, and inherit was a function that took storage as a parameter... alas.

Edit: Wait, that doesn't even work; we don't save anything to preferences unconditionally. Well, darn. I guess you would have to do the fairly silly path of pushing a release that stores the preference key with one value, waiting for it to be likely that everyone has that version, then changing the default for future users.

https://github.com/AprilSylph/XKit-Rewritten/blob/f826d67e0c8fe6c36bb9eab88cf9e2b7954a1083/src/util/preferences.js#L21-L31