AprilSylph / XKit-Rewritten

🧰 The enhancement suite for Tumblr's new web interface
GNU General Public License v3.0
281 stars 48 forks source link

No Recommended not hiding recommended tags #1335

Closed krookodilehunter closed 8 months ago

krookodilehunter commented 8 months ago

Platform

Windows 10

Browser

Brave 1.60.125

Addon version

v0.23.1

Details

despite having the recommended tags option selected, i am still seeing recommended tags. reloading the page sometimes works but it doesn't all the time. i've also noticed that when the recommended tags are on my dashboard, some posts are blocked from showing up, but are able to be seen if the recommended tags block is gone.

image

luxidoptera commented 8 months ago

Corroborating. This is happening to me too. image

Also extends to other between-post recommendation windows. image

Avakining commented 8 months ago

Corroborating as well. Recommended blogs are also appearing.

Screenshot 2023-11-30 at 17 55 30

XKit Rewritten 0.23.1 Firefox 120.0.1 macOS 14.1.2

inklesspen commented 8 months ago

The CSS has changed for blog carousels. It used to use blogCarousel, but now uses carouselWrapper.

taracdia commented 8 months ago

This is also occurring in Firefox nightly (Android Mobile)

marcustyphoon commented 8 months ago

You can assign multiple people to each issue or pull request, including yourself, anyone who has commented on the issue or pull request, anyone with write permissions to the repository, and organization members with read permissions to the repository. – https://docs.github.com/en/issues/tracking-your-work-with-issues/assigning-issues-and-pull-requests-to-other-github-users

Apparently I can't assign this issue even if a PR is set to close it! Thanks GitHub.

arcanetrivia commented 8 months ago

I suppose this "Top X blogs" carousel in the middle of a tag page is the same idea? image

vivacious-cat commented 1 month ago

Hi there, just wanting to check if this has been repaired? Current user, and having same issue on Firefox in June 2024... reccomended blogs still showing

marcustyphoon commented 1 month ago

I haven't checked the code to be sure, but this should probably be fixed in version 1.0.0, which we've submitted to Mozilla for review! It usually takes a few days.

marcustyphoon commented 1 month ago

@vivacious-cat This should be fixed in v1.0.0, which is now out for all platforms; if you update and close+reopen your Tumblr tab and it's still not fixed, please file a new issue!