search

AprilSylph / XKit-Rewritten

🧰 The enhancement suite for Tumblr's new web interface
GNU General Public License v3.0
293 stars 48 forks source link

Shorten Posts: Button intersects search box/dropdown (minor) #1400

Open marcustyphoon opened 8 months ago

marcustyphoon commented 8 months ago

Platform

MacOS 13.2.1 arm64

Browser

Chrome 121.0.6167.139, Safari 17.2.1

Addon version

0.23.3

Details

Screenshot 2024-02-19 at 7 46 50 PM Screenshot 2024-02-19 at 7 47 09 PM

Because the z-index property of both the shorten posts expand button/tags and the search box that floats over search result pages is 2, they intersect unexpectedly.

Should be fixable with isolation: isolate; on the article.

marcustyphoon commented 7 months ago

Should be fixable with isolation: isolate; on the article.

This has the slight potential to do bad things. XKit's popup elements—the ones from Quick Reblog and Quick Tags—will appear broken if they're inside an element with this applied. It's not usually possible to click control buttons on shortened posts, though, since the expand button covers the post controls, so you generally have to go out of your way to experience this in practice (e.g. by vertically resizing the browser window), and clicking expand fixes it.

Tumblr's code, as far as I know, uses popper.js and glass container and whatnot rather than actually z-indexing a real child element of a post to make a popup, so this shouldn't cause any issues, but it's not impossible that that could happen in the future.

Or, you know, redpop could use a z-index that differs by more than 1. That's also an option.