marcustyphoon
commented
5 months ago Needs tweaking:
- [ ] Themed Posts
- [x] "Restore attribution" tweak
- [ ] NotificationBlock
- [ ] Quick Tags
- [ ] Trim Reblogs
- [ ] Show Originals
Maybe:
- Mutual checker works with no changes on Communities pages, but it's firing API requests unnecessarily rather than parsing
authorBlogwhenblogdoesn't match. The code change to improve this is somewhat awkward, though. I can't test Quick Tags on Communities.I can't test Trim Reblogs on Communities.I can't test NotificationBlock on Communities (blockPostFilter may be wrong, and the apiFetch to check if the post is muted probably crashes if the button actually is clickable? most likely fine though)
Platform
MacOS 14.4.1 arm64
Browser
Chrome 123.0.6312.87
Addon version
v0.23.4
Details
Needs tweaking:
Maybe:
authorBlogwhenblogdoesn't match.The code change to improve this is somewhat awkward, though.#1576I can't test Quick Tags on Communities.I can't test Trim Reblogs on Communities.I can't test NotificationBlock on Communities (blockPostFilter may be wrong, and the apiFetch to check if the post is muted probably crashes if the button actually is clickable? most likely fine though)The Tumblr Communities feature, which is currently in a closed beta, contains posts that work differently than other posts in the Tumblr ecosystem, and also include changes to the way the API data underlying posts are used. This currently causes/probably will cause some XKit Rewritten functionality not to work properly within communities.
Particularly, community posts are displayed (generally speaking) as if they belong to the blog of the user who composed them, but the API data is more similar to a submission from that user to a generic blog.
In the case of Themed Posts, this just results in erroneous behavior: we want to match the theme we render a post with the way it otherwise appears, so we'll need a method to get a post's "blog" that isn't actually just the
blogproperty of its API data. A number of other scripts look like they'll fall into this category (I can't tell right now; I'm not in the beta).In some other cases, it would make sense for scripts to treat the submitting blog of a submission equally with the owning blog. For example, Quick Reblog automatically suggests a tag for the blog name; it may as well suggest the submitting blog's name too. In these cases there doesn't need to be special behavior for community posts.