search

AprilViolet / highlight-bracket-pair

🎉Highlight bracket pair plugin for intellij
GNU General Public License v3.0
47 stars 6 forks source link

update foreground color in BRACE_ATTR_GUTTER #16

Closed rala72 closed 2 years ago

rala72 commented 2 years ago

background and foreground color was the same

AprilViolet commented 2 years ago

Hi, because it's the Chinese new year recently, I haven't paid attention to this project recently. In fact, BRACE_ATTR_GUTTER is only useful for the foreground color, and the background color does not take effect in the setting, so maybe deleting the background color is a better choice

rala72 commented 2 years ago

interesting the preview looked different but if it is the case feel free to do so and close this PR

just curious: what is the system of choosing the colors? some combination have not a good contrast in my opinion

AprilViolet commented 2 years ago

Yes, BRACE_ATTR_GUTTER affects the color of the parentheses on the left, the background color is useless here, at least I set it outless here.You can try it

rala72 commented 2 years ago

ah, I know I understand what the color is about 🤦‍♂️ so this removing would be the best option this PR can be closed then

therefore, I now understand what it is about, is it possible to move Other settings > HighlightBracketPair > Open reder bracket in gutter to Editor > General > Gutter Icons? I think this would be better as issue

AprilViolet commented 2 years ago

Yes, according to the function, it is more appropriate to put it under gutter icons, but the plugin has other settings at present or in the future. Maybe it is more appropriate to put it together, so that users can configure it in one place.