search

AprilViolet / highlight-bracket-pair

🎉Highlight bracket pair plugin for intellij
GNU General Public License v3.0
47 stars 7 forks source link

🐛 fix: fix configuration menu plugin compatibility #24

Closed Noorts closed 2 years ago

Noorts commented 2 years ago

Hey @AprilViolet, I'd like to make you aware of a compatibility issue I ran into recently between your plugin and my Toggler plugin.

The configuration menus set up by our plugins use a class called ApplicationConfigurable, which is configured as an extension in our plugin.xml. This configuration includes an identifier which should be unique, else conflicts between plugins will occur and the configurations menu's won't show up.

Now, because we both used the JetBrains' plugin template the identifier in both our plugins was set to a default value. This caused an error for a developer using both plugins as discussed on the following GitHub issue.

I just pushed out an update for my plugin to remedy the issue but would also highly recommend you to push out an update as I expect many other plugin developers have used the plugin template and haven't updated the value from the default one, causing conflicts if both plugins are installed.

Again, I highly recommend checking out the issue for more information.

AprilViolet commented 2 years ago

@Noorts Thank you for raising this question and submitting PR.