search

AprupKale / pe

0 stars 0 forks source link

App accepts invalid birthdays #5

Open AprupKale opened 11 months ago

AprupKale commented 11 months ago

App lets me input invalid birthdays without displaying an error message or a warning.

An apt error message should be displayed should the user try to enter invalid birthdays instead of accepting them.

image.png

image.png

image.png

image.png

nus-pe-bot commented 11 months ago

Team's Response

Thanks for bringing this up! We have indeed noticed this issue too and as such, mentioned it in the Known Issues of UG and Planned Enhancements of DG as shown in the pictures below.

image.png Known Issues of UG

image.png Appendix: Planned Enhancements of DG

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I believe that the response should be response.NotInScope as the UG mentions that you plan on enhancing our Birthday class by manually adding checks in isValidBirthday to detect invalid dates, and according to the bug triaging guidelines, it is considered NotInScope but cannot be Rejected and can be considered a type.FeatureFlaw instead of my original type.FunctionalityBug (see below)

image.png