[Bug] instance.UI.setActiveLeftPanel not working in modular UI

[Olliwehr]

When calling instance.UI.setActiveLeftPanel in combination with the modular UI, I encountered some strange behaviour.

WebViewer version

• 10.10.1 both UI and Core
• Modular UI (ui set to "beta")

The current behavior There are no changes in regard to the active panel, not just when calling it with "thumbnailsPanel" but any other (valid) panel of yours.

Also, the browser console shows the following warning:

The expected behavior

• No console warning
• the panel that is supposed to be set is actually set to active

Steps to reproduce Call instance.UI.setActiveLeftPanel("thumbnailsPanel") and take a look at the browser console

Solution Idea I had a look at the code (./src/helpers/isDataElementLeftPanel.js) and noticed that it would probably only require the following change:

  if (customizableUI) {
    return state.viewer.genericPanels
      .filter((item) => item.location === PLACEMENT.LEFT)
      .map((item) => item.dataElement);
  }

instead of

  if (customizableUI) {
    return state.viewer.genericPanels.filter((item) => item.location === PLACEMENT.LEFT);
  }

as you filter for inclusion of concrete data-elements afterwards.

[bollain]

Hi @Olliwehr!

Thanks for submitting this issue with a corresponding PR. We have a ticket in our backlog to fix this; with the new modular UI the tab panel can live either on the left side, or the right side, so we are creating a new API specific to the new abstraction of the modular Tab Panel.

We will also review your solution in the open PR, as it may provide a stop-gap solution while we roll out the new API. I'll update this ticket when we have a closer look.

Thanks for submitting this and testing out the new modular UI!