Aptoide / appcoins-wallet-android

AppCoins Wallet repo
https://appcoins.io
GNU General Public License v3.0
76 stars 45 forks source link

[WAL-54] Fingerprint remaining integration #956

Closed JDSM01 closed 4 years ago

JDSM01 commented 4 years ago

What does this PR do?

Makes the following changes to the already existing fingerprint integration:

Database changed?

No

Where should the reviewer start?

AuthenticationPromptActivity.kt

How should this be manually tested?

Check the 4 flows that require authentication (iap, entering wallet, remove wallet, disable authentication) with fingerprint Disable device fingerprint and check if you are able to enter the wallet and the fingerprint settings is off and unable to set it on (future task) On a device without fingerprint hardware check if the settings does not appear on settings

What are the relevant tickets?

https://aptoide.atlassian.net/browse/WAL-54

Code Review Checklist

franciscoaleixo commented 4 years ago

On my device, there's a bug reactivating the fingerprint. Steps to replicate: