Closed JDSM01 closed 3 years ago
What does this PR do?
Removes last page of the onboarding Made changes to make onboarding match new discussed architeture Moved warning text below T&C in portrait and adjusted margins to fit in smaller devices
Database changed?
No
Where should the reviewer start?
OnboardingActivity.kt OnboardingPageChangeListener.kt OnboardingPresenter.kt
How should this be manually tested?
Go through Onboarding in both portrait and landscape
What are the relevant tickets?
https://aptoide.atlassian.net/browse/WAL-89
Questions:
Does this add new dependencies which need to be added? (Eg. new libs, new keys, etc.)
Code Review Checklist
What does this PR do?
Removes last page of the onboarding Made changes to make onboarding match new discussed architeture Moved warning text below T&C in portrait and adjusted margins to fit in smaller devices
Database changed?
No
Where should the reviewer start?
OnboardingActivity.kt OnboardingPageChangeListener.kt OnboardingPresenter.kt
How should this be manually tested?
Go through Onboarding in both portrait and landscape
What are the relevant tickets?
https://aptoide.atlassian.net/browse/WAL-89
Questions:
Does this add new dependencies which need to be added? (Eg. new libs, new keys, etc.)
Code Review Checklist