Aptoide / appcoins-wallet-android

AppCoins Wallet repo
https://appcoins.io
GNU General Public License v3.0
75 stars 45 forks source link

[WAL-94] Card number error icon overlapped by card icon #977

Closed JDSM01 closed 3 years ago

JDSM01 commented 3 years ago

What does this PR do?

Removed error icon since it was being overlapped by the card icon. It was first attempted to move the card icon to the left, but in some devices it would overlap the card numbers. Since in the first attempt I had to convert dp to px, I ended extracting that logic to an extension function.

Database changed?

No

Where should the reviewer start?

AdyenTopUpFragment.kt AdyenPaymentFragment.kt

How should this be manually tested?

Check if the icon appears in both topup and iab layouts

What are the relevant tickets?

https://aptoide.atlassian.net/browse/WAL-94

Questions:

Does this add new dependencies which need to be added? (Eg. new libs, new keys, etc.)

Code Review Checklist