Aptoide / aptoide-uploader

31 stars 16 forks source link

[MOB-373] fix: wrong obb being uploaded when multiple files (of the same type) #24

Closed jdandrade closed 4 years ago

jdandrade commented 4 years ago

What does this PR do?

Fixes the issue that exists when multiple obb's of the same type (main for example) exist in the Android/obb/ folder. This happens because listFiles doesn't guarantee order, so the first file that it lists will be the one being uploaded. This is an issue because if the user updates an app with obb's along multiple versions, depending on how the App Store handles file management, it might leave old version files behind (in Aptoide we do not clean obb's when installing a newer version, so it actually contributes to the error). What I've ended up doing was a simple sort by modified date DESC so it mitigates this problem, but it doesn't solve it.

Where should the reviewer start?

How should this be manually tested?

Flow on how to test this or QA Tickets related to this use-case: MOB-373

What are the relevant tickets?

Tickets related to this pull-request: MOB-373

Code Review Checklist