search

Aptronics / aptronics

Other
0 stars 1 forks source link

Why does Sales Order list show "Drop Shipped" #29

Open hpema opened 4 years ago

hpema commented 4 years ago

Hi Team,

Is the status customisable?

Why does the sales order status show "Drop shipped" when we not clicking on the dropship checkbox and only adding the supplier, is this a side effect of our changes for raising POs from sales order?

image

agritheory commented 4 years ago

"Drop Shipped" is a non-standard status that is being added via monkey patch. So in this case, we have control over the logic, but it is duplicated and need to be synchronized between two places: https://github.com/Aptronics/aptronics/blob/master/aptronics/status.py#L9 and https://github.com/Aptronics/aptronics/blob/master/aptronics/public/js/custom/sales_order_list.js#L27

We can change it to any logic you require.

SaiFi0102 commented 4 years ago

And also make sure none of the Item Masters have "Is Drop Shipped" enabled. Also make sure that Drop Shipped in not checked in Sales Order Items. If it is, then it's expecting the supplier to deliver directly to the customer.

agritheory commented 4 years ago

@hpema We should build a statechart/ diagram for this workflow. It will help with both users and the design requirements.