AquaAuma / FishGlob_data

Database and methods related to the manuscript "An integrated database of fish biodiversity sampled with scientific bottom trawl surveys"
Creative Commons Attribution 4.0 International
21 stars 7 forks source link

Ed Lavender on fix (2) #16

Closed AquaAuma closed 11 months ago

AquaAuma commented 1 year ago

Verbatim names. I noticed at least one record in the dataset where the verbatim name refers to eggs, whereas I think you are focusing on juveniles/adults.

@jepa

jepa commented 11 months ago

This issue was in the SCS survey, specifically:

I explored the clean_taxa() function and it deos not capture this because worrms does identify _HEMITRIPTERUS AMERICANUS as a name, regardless of the "egg" part. Need to think on a overall fix.

@AquaAuma in the meantime, can you re-run the get_scs.R or we can just filte out those two species from the dataset?

AquaAuma commented 11 months ago

if the taxonomic function does not fix this issue, we can filter directly in the R code, I think that's fine as we've done this elsewhere too I think

jepa commented 11 months ago

Done manually and updated the dataset in the googleDrive. Note that I was not able to run the FAGS part

AquaAuma commented 11 months ago

I don't use the ggdrive anymore for the public repo, where is the dataset you're talking about? What's the FAGS part?

jepa commented 11 months ago

Fixed issue, see 087d96b05f8f2df0ea45f42b900f4bdaa416ceef for data, cleaning code and summary and bb8d9ee49b9d849162af283d2d1608149a55ab59 for the FAGS part