search

AquaSat / AquaMatch_harmonize_WQP

https://aquasat.github.io/AquaMatch_harmonize_WQP/
MIT License
1 stars 3 forks source link

Consider reworking the site grouping process to have only one target #21

Closed mbrousil closed 2 months ago

mbrousil commented 1 year ago

I recently broke up p2_site_counts_grouped into multiple targets, e.g. p2_site_counts_grouped_chl, p2_site_counts_grouped_sdd so that errors in one parameter wouldn't affect others downloading. I think the ideal situation is to have them all under a single branching target so that they're still done independently but via automation. Need to look into this.

mbrousil commented 1 year ago

@steeleb if you have a few minutes to look at this, do you have any opinions about whether branching would be more useful than hard-coding here? It's referring to the comment here. The concept applies down through L160

(...and then in the next section a few lines lower, referenced in #22)

steeleb commented 1 year ago

I think this is a great opportunity to use branching! Do you want me to take a closer look at add_download_groups() to implement?

mbrousil commented 1 year ago

If you're up for it!

steeleb commented 1 year ago

Totes! self-assigning. Once I get the lakeSR pull running (in the next 30 or so) I'll get this sketched out in a GH branch.