AquaSat / AquaMatch_harmonize_WQP

https://aquasat.github.io/AquaMatch_harmonize_WQP/
MIT License
1 stars 3 forks source link

Consider redefining definition of duplicates to avoid dropping unnecessarily #30

Closed mbrousil closed 11 months ago

mbrousil commented 1 year ago

I'll note that the columns used to check for duplicates do not include depth. It is common for multiple samples/measurements of the same parameter at varying depths to be obtained at a specific location and date/time. Additionally, it looks like the code drops all duplicates and doesn't retain any? This might be me not completely understanding the 'remove_duplicated_rows' function.

_Originally posted by @steeleb in https://github.com/rossyndicate/aquasat_v2/pull/29#discussion_r1307701336_