search

AquaSat / AquaMatch_harmonize_WQP

https://aquasat.github.io/AquaMatch_harmonize_WQP/
MIT License
1 stars 3 forks source link

Rewrite chlorophyll tiering and harmonization #35

Closed mbrousil closed 1 year ago

mbrousil commented 1 year ago

This PR updates the chlorophyll harmonization process (3_harmonize/src/harmonize_chla.R) with analytical method tiering and field tiering. This is the major change, though there is a new file, 3_harmonize/out/chla_tiering_record.csv that serves to document the outcomes of analytical method tiering here. Somewhere along the way the tss harmonization file got deleted and reinstated so that's in here too but there's no changes.

@matthewross07 @mishafredmeyer you are both tagged here so you can weigh in on the tiering methods and if they should change at all. Lines 407-422 of 3_harmonize/src/harmonize_chla.R spell out the tiering philosophy. 3_harmonize/out/chla_tiering_record.csv is the best place to see the results of the analytical method tiering. This file is where the field tiering is spelled out, which I know we may not be fully settled on. I'll wait to merge until everyone's given the thumbs up and in the meantime work on updating tiering for the other parameters, which should be less involved.

steeleb commented 1 year ago

I'll be looking at this today! I just tagged @kathryn-willi, too, as she will have good insight and asked to be kept in the loop.