add map pattern at L60 and L 210

[steeleb]

I'm not 100% that this will (a) not break your code or (b) if it ends up outputting what you'd expect, soooooo I'm putting this in it's own branch. Full disclosure, I have no idea how {targets} handles iteration AND pattern.

If it doesn't work, remove these two issues from the Development pane (on the right), and delete this branch, but in theory, it should work?

Closes #21 Closes #22

[mbrousil]

Beans, this doesn't work for me...When I run it I get an error for p2_site_counts_grouped:

• start branch p2_wqp_data_aoi_3d309911
Error: arguments cannot be recycled to the same length

✖ error branch p2_wqp_data_aoi_3d309911
• start branch p2_wqp_data_aoi_094543a1
Error: arguments cannot be recycled to the same length

✖ error branch p2_wqp_data_aoi_094543a1
• start branch p2_wqp_data_aoi_df85745a
Error: arguments cannot be recycled to the same length

✖ error branch p2_wqp_data_aoi_df85745a
• start branch p2_wqp_data_aoi_7925d0f3
ieving WQP data for 196716 sites in group 9343_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 9523_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 9597_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 9598_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 9733_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 9777_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 9778_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 9911_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 9912_01, Total suspended solids for 196716 sites in group 13879_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 13880_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 14053_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 14056_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 14057_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 14058_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 14059_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 14230_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 14233_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 14234_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 14235_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 14236_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 14410_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 14411_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 14412_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 14413_01, Total suspended solidsRetrieving WQP data for 196716 sites in group 14414_01, Total suspended solidsRetr
Error: attempt to set an attribute on NULL

✖ error branch p2_wqp_data_aoi_7925d0f3

[steeleb]

Dang. I was hoping it was easy. I do think this means that the p2_site_counts_grouped was successful though? If so, it may be as easy as NOT mapping over the groups, and letting targets do it's magic since sometimes it's a little smarter than us?

Task one: can you confirm that p2_site_counts_grouped was successful. Task two: will tar_load(p2_site_counts_grouped) and send me a screen shot of what's there?

[mbrousil]

Dang. I was hoping it was easy. I do think this means that the p2_site_counts_grouped was successful though? If so, it may be as easy as NOT mapping over the groups, and letting targets do it's magic since sometimes it's a little smarter than us?

Task one: can you confirm that p2_site_counts_grouped was successful. Task two: will tar_load(p2_site_counts_grouped) and send me a screen shot of what's there?

Yep, here's what I get:

[steeleb]

hmmm - this is one that's really hard to troubleshoot without having a bunch of the targets to play with. I think this may go back to some interaction of iteration and pattern (and me not knowing what the previous {targets} output looks like). I think there are a few ways forward: 1) leave it as it is (it is functional right now, so don't fix what isn't broken 2) I can try to run the whole damn thing and start troubleshooting from my end 3) I'd have you send me your _targets folder - but I think that's probably stupidly large.

Either way I think this might require 1-2h for me to really a) grasp what is currently happening and b) then figure out how to do it as a branched target. I'd be interested in what @matthewross07 has to say about this!

[steeleb]

Heya - I royally messed up this PR by fetching main... into my main branch because a really smart data scientist didn't make these changes in a branch on their own fork..... so I'm going to close, but not merge and then absolutely destroy my fork. #facepalm.