search

AquaSat / AquaMatch_harmonize_WQP

https://aquasat.github.io/AquaMatch_harmonize_WQP/
MIT License
1 stars 3 forks source link

Mixed bag of polishing changes #86

Closed mbrousil closed 6 months ago

mbrousil commented 6 months ago

Heya! Here's what's going on here:

  1. Site metadata: Added in site metadata targets to pull, clean, export the site info we need. (3_harmonize/src/clean_wqp_data.R, 3b_harmonize_chla.R, 3c_harmonize_doc.R)
  2. Export harmonization files to Drive: Outputs in the harmonization workflow weren't being exported previously but now they are. Modified the method being used in the download pipeline for this. (3_harmonize/src/export_single_file.R, config.yml, _targets.R, 3b_harmonize_chla.R, 3c_harmonize_doc.R)
  3. Add harmonized_value to preagg data: This column seems to have been overlooked when grouping was taking place, so I've added it in. (3_harmonize/src/harmonize_chla.R, 3_harmonize/src/harmonize_doc.R)
  4. Re-run after changes: All the small files that are changed are from rerunning with a new stable date
  5. Add an informational paragraph to chla harmonization documentation: Informs the users about the pheophytin situation with the Narrowed tier (bookdown_raw/04_chla_harmonization.Rmd)
mbrousil commented 6 months ago

Merge this sucker!

And honestly, don't worry about the site branching thing in #87. 45 seconds isn't worth the labor IMO.

Thanks!