search

AquaSat / AquaMatch_harmonize_WQP

https://aquasat.github.io/AquaMatch_harmonize_WQP/
MIT License
1 stars 3 forks source link

Config documentation updates #99

Closed steeleb closed 3 months ago

steeleb commented 3 months ago

Okay, here it is! Lots of words, few people will likely ever read them. I also replace the #### subheaders with bold because I don't think we have subheader depth defined anywhere and we have a guideline to use 3 or fewer levels. (This is a thing that MR mentioned offhandedly a while back, sorry if I didn't loop you in!)

Of note, I changed the _targets.R file to default to run the use_stable configuration - I know we've debugged the admin_update and now the use_stable configs, but I don't know that we've run the default configuration explicitly. If I'm wrong about this, we should probably set line 31 in _targets.R to default for our public-facing branch.

Related: while it makes sense for the 'public facing' branch to have that config set to default or use_stable, it doesn't necessarily make sense for the branch we're developing on. Maybe we create a develop branch after the chl-a data/pipeline gets published that we work in and release/merge with main as we publish new parameters? Tagging @mishafredmeyer and @matthewross07 here in case they have thoughts.

steeleb commented 3 months ago

I think I agree with the suggestion about the develop branch! I would be interested to hear if @matthewross07 has preferences

And I think we can pause on that until chl-a is officially published, but agree, getting @matthewross07 advice here would be great.

steeleb commented 3 months ago

Closing after reverting a few things per PR suggestions!