Aquantia / aqtion-freebsd

Aquantia AQC multigigabit NIC FreeBSD driver - development preview
Other
36 stars 19 forks source link

Newer ASUS XG-C100C pci card mac fw issue #24

Open bradgranath2 opened 2 years ago

bradgranath2 commented 2 years ago

I have a recent ASUS XG-C100C. pciconf (as well as the Windows-based FIrmware Update Tool, show it to have a Vendor ID of: 94c0

I've tried building the driver with this Vendor ID added to aq_main.c, and it builds and loads just fine. However, dmesg reports via aq_log() "FLB> F/W successfully loaded from flash." , but then immediately after, returns "-16", which I take to be wait_init_mac_firmware_(hw) returning -EBUSY. The only thing that wait_init_mac_firmware_() does is loop until AQ_READ_REG(hw, 0x18)) != 0 or return -EBUSY if nothing happens.

I'm guessing that the register is different for the new ACQ107 chip revision? Gonna go see if the linux driver has any clues, but I figured I'd leave this here in case anyone else is coming across this problem with the new batch.

cail commented 2 years ago

Hi @bradgranath2,

Your device is AQC113 based - its a next generation chip, and its not driver-level compatible with AQC107 family.

Unfortunately this is not supported in freebsd driver. To my knowledge, there will be no official extension of freebsd drivers for this chip. Linux driver although, has all the support in there.

bradgranath2 commented 2 years ago

All info I can find on the card online indicates it should have a 107, not a 113, although that would certainly explain the issue. How were you able to find this?

https://www.marvell.com/content/dam/marvell/en/public-collateral/ethernet-adaptersandcontrollers/marvell-fastLinq-edge-aqc113-aqc113c-aqc113cs-aqc114cs-aqc115c-aqc116c-product-brief.pdf

This datasheet from Marvell says that the AQC113 has FreeBSD 12 support. Which doesn't make sense because it is not in the hardware support list (because it is the chip name not the card name?) This is also the chipset in the M1 mac and the Intel NUC 12?

cail commented 2 years ago

94C0 is a device ID of AQC113 family.

Unfortunately thats a mistake in the product brief I think (

Its hard to say because M1Mac may have both 107 and 113 chipsets. PCI devid definitely answers your question: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/drivers/net/ethernet/aquantia/atlantic/aq_common.h#n42

bradgranath2 commented 2 years ago

Exactly what I was looking for, thank you.