search

AquaticEcoDynamics / GLM

Code for the General Lake Model
http://aquatic.science.uwa.edu.au/research/models/GLM/
GNU General Public License v3.0
35 stars 29 forks source link

Flexible time of day to initiate simulations #11

Closed rqthomas closed 5 years ago

rqthomas commented 5 years ago

I see that there are modifications to the code to allow the user to specify the time of day that simulations are initialized. This is super helpful for data assimilation, especially when assimilating observations done in the middle of the day.

I have tried to use the latest version with start = 2018-07-12 12:00 and test by examining the output solar radiation values (with sub-daily output). My tests seem to suggest that the updates are not working because the solar radiation always starts with zero values before ramping up to mid-day values regardless of the hour specified in the start time. Is the starting hour capacity fully functional, is there a potential issue, or am I not implementing it correctly?

Thanks for any insight!

rqthomas commented 5 years ago

This was fixed in commit 8ecfcb6. Thanks!