search

AquaticEcoDynamics / GLM

Code for the General Lake Model
http://aquatic.science.uwa.edu.au/research/models/GLM/
GNU General Public License v3.0
35 stars 29 forks source link

Fixing multiple segmentation faults #18

Closed rqthomas closed 5 years ago

rqthomas commented 5 years ago

I was getting segmentation faults randomly with AED turned on. There are three places that I have isolated the issues. They all have to do with how the code "looks" up and down the benthic zones. In all cases they are referencing indices of vectors that have not been initialized so the numbers used in the calculations are whatever was in memory previously. Please review to see if my solutions work based on your understanding of how the indexing works in GLM.

rqthomas commented 5 years ago

Thanks @casper-boon for pulling this into the main branch.