AquaticEcoDynamics / GLM

Code for the General Lake Model
http://aquatic.science.uwa.edu.au/research/models/GLM/
GNU General Public License v3.0
35 stars 29 forks source link

Weir flow calculation could be off #51

Open rqthomas opened 2 months ago

rqthomas commented 2 months ago

If the flow is expected to be in m3/day is seems that the weir flow has the units in m3/sec but this is divided again by number of seconds in a day in the do_single_outflow. Not sure if this is an issue but worth following up on.

https://github.com/AquaticEcoDynamics/GLM/blob/4f1503670c2cafe9b1a85d759208b97fae5ebb01/src/glm_flow.c#L504