Changes to diagnostic variables in order and number

[MichaelBarryBMT]

Hi Casper and Matt

Happy new year!

This is a request for three overall changes to the pelagic diagnostic variable calcs/outputs in libaed-water. Hopefully they are pretty simple and OK - I know that changes to variables/diag variables can cause angst though, so am happy to chat.

The request is three fold (in the order shown in the code below):

1. aed_organic_matter

• Only creating the 'cpom_vvel' diag when cpom (refractories) are simulated.

2. aed_phytoplankton

• Creating three new diagnostics that are primary productivity, net primary productivity and sedimentation for each phyto group. These are only included as summed diag variables at present I think, which means users can't drill down into the detail of each phyto group's growth behaviour. Having these extra diagnostics would really help calibration I think, and complement the summed diagnostic nicely.

3. aed_sedflux

• The fsed sheet diagnostics are not created in the same order as variables (or the other parallel non-sheet diagnostics) so this is a request to change that order here to be consistent from the user's point of view and that of other variables. It moves carbon diags to between DO and silicate, and rearranges the suite of organic fsed sheet diags to be the same order used elsewhere: POC, DOC, PON, DON, POP, DOP

Thanks

MB

[matthipsey]

HI MB - thanks for these updates; they look fine to me so have merged into the base.

[MichaelBarryBMT]

Thanks Matt MB