search

AquaticEcoDynamics / libaed-water

Code for the AED water quality model
GNU General Public License v3.0
6 stars 6 forks source link

id_Psed_phy and id_PhySed units #33

Closed MichaelBarryBMT closed 2 years ago

MichaelBarryBMT commented 2 years ago

Hi Matt

I noticed in my mass balance work that the units of sedimentation for phytos are mmol/m2/sec, and are reported in the group and community diagnostics as such. The other sediment related diagnostics like FSed are reported in mmol/m2/day. This is potentially confusing for users who might assume that all sediment related fluxes are reported in the same units (I did and it took me a while to work out what was going wrong!!).

Is it possible to make the units of all sediment fluxes /m2/day, instead of a combination of /m2/s and /m2/day? I realise tat this may have impacts more broadly than I have considered (e.g. in the sediment diagenesis module perhaps, and I see that id_Psed_poc, id_Psed_pon and id_Psed_pop are reported in /m2/s too)) but for the majority of consulting users who will be simulating DO, inorganics, organics and phytos, this change of units between sed fluxes might be a pitfall that can be avoided.

Thanks

MB

matthipsey commented 2 years ago

Hi MB Thanks fro picking this up. The intent is that diagnostiucs for reporting are /day, but the vertical sedimentation fluxes are still /s, as they are being linked across modules for use - and "internally" everything is /s. Before acting this change I will just need to make sure that linkers of Psed_phy will apply the unit correction properly. M

MichaelBarryBMT commented 2 years ago

Thanks Matt

The additions to the group Pseds are great - all in /d now. The community diag is still in /s if that was able to be modified too without causing headaches elsewhere?

Also, the labile and refractory particulate organics DIAG fluxes are in /s units. I know there are linkages with other modules but it'd be convenient for users to have these also converted to /d DIAGS, just on the lines below, if possible please. Not urgent as I have made fixes between AED and FV to cover this, but when/if it is converted to /d inside AED I will need to roll these intermediate fixes back.

Ta MB

image